-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/unified clob #1
base: development
Are you sure you want to change the base?
Conversation
example: serum | ||
name: | ||
type: string | ||
example: 'SOL/USDT' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe it would be interesting to add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
docs/swagger/clob-beta.yml
Outdated
items: | ||
type: string | ||
example: | ||
- 'SOL/USDT' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, similarly maybe it would be interesting to add some ripple exames here
properties: | ||
name: | ||
type: string | ||
example: USD.rh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx/VND.rh8LssQyeBdEXk7Zv86HxHrx8k2R2DBUrx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, If this info here is also the market/contract address, I think it is a good idea to fill the address property that serum has as well.
example: solana | ||
network: | ||
type: string | ||
example: mainnet-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe we can add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
example: mainnet-beta | ||
connector: | ||
type: string | ||
example: serum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe we can add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
example: solana | ||
network: | ||
type: string | ||
example: mainnet-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
example: mainnet-beta | ||
connector: | ||
type: string | ||
example: serum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
properties: | ||
chain: | ||
type: string | ||
example: solana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
properties: | ||
chain: | ||
type: string | ||
example: solana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
example: solana | ||
network: | ||
type: string | ||
example: mainnet-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
example: mainnet-beta | ||
connector: | ||
type: string | ||
example: serum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe add a ripple example here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
docs/swagger/clob-beta.yml
Outdated
CLOBGetMarketsResponseItemCommon: | ||
type: object | ||
properties: | ||
name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, maybe change to id
docs/swagger/clob-beta.yml
Outdated
name: | ||
type: string | ||
example: 'SOL/USDT' | ||
names: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mlguys, it seems that in the swagger parser the examples are coming as an array inside an array for all of the arrays definitions like these one.
Creating this temporary PR so we can add comments ;)