_autoStartSegment #494
Open
_autoStartSegment #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 75.40% 75.21% -0.20%
==========================================
Files 41 41
Lines 5924 5939 +15
Branches 946 951 +5
==========================================
Hits 4467 4467
- Misses 1298 1313 +15
Partials 159 159 |
|
This is great, thank you! Before pulling this in, would it be possible to add some tests? |
|
Hello, we are currently working on variomatic for interpolation, i will definitely report on this. So far it looks like its working, when we have more tests on letters i will inform, although we have our own contour sorting, ill check about _autoContourOrder as well. Keep this open please! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XXX port this from robofab