Add args flag removal to 1.0 proposal #2150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the credits goes to @itscaro's work at roboll/helmfile#2084. The only change I made is related to the main branch rename.
Signed-off-by: yxxhero <[email protected]>
Add an issue form for bug report
remove ioutil usage in all project
Signed-off-by: yxxhero <[email protected]>
add unittest for formatters.go
Signed-off-by: yxxhero <[email protected]>
mv captureStdout as public func
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
Signed-off-by: yxxhero <[email protected]>
[test] update helm 3.8.0 to 3.8.1
add unittest for load_opts.go
bump go 1.18 & remove .circleci
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
Signed-off-by: Quan TRAN <[email protected]>
Signed-off-by: Rodrigo Dantas <[email protected]>
Signed-off-by: Rodrigo Dantas <[email protected]>
Signed-off-by: Philipp Eckel <[email protected]>
Update sops version on dockerfile
Update Helm diff plugin to version 3.5.0 in Dockerfile
Bumps [github.com/imdario/mergo](https://github.com/imdario/mergo) from 0.3.12 to 0.3.13. - [Release notes](https://github.com/imdario/mergo/releases) - [Commits](darccio/mergo@0.3.12...v0.3.13) --- updated-dependencies: - dependency-name: github.com/imdario/mergo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…m/imdario/mergo-0.3.13 Bump github.com/imdario/mergo from 0.3.12 to 0.3.13
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
add e2e tmpl test
reconstruct main function
Signed-off-by: yxxhero <[email protected]>
little code optimize
* Adds feature to fetch environment values from remote The releases and environment section allow for values files on the local disk. This enhancement allows for referencing remote (go-getter) files to be fetched, cached and referenced. In addition when fetching a remote git source with a ssh key the ssh key will not be part of the caching folder name. This avoids two problems: 1. Don't leak sensitive information in the name of the caching folder 2. Base64 encoded SSH keys are very long. On some file systems the max lenght of the directory name is hit when using the full base64 information in the path name. The sshkey informations are reducted. Because of this fixed string there is a change of colloding cache names. The likelihood of this collision is very low. The git repo and git reference need to be the same, but the sshkey can change. This will result in the same source to be checkout out and referenced. Signed-off-by: Lüchinger Dominic <[email protected]> * Update pkg/state/storage.go Co-authored-by: Yusuke Kuoka <[email protected]>
…tions (#1) * introduce DISABLE_INSECURE_FEATURES to disable insecure executions Signed-off-by: Quan TRAN <[email protected]> * disable remote sources when DISABLE_INSECURE_FEATURES is set to "true" Signed-off-by: Quan TRAN <[email protected]> * refactor envvar package Signed-off-by: Quan TRAN <[email protected]> * (test) fix test fixtures Signed-off-by: Quan TRAN <[email protected]> * use absolute path to avoid unit test failure Signed-off-by: Quan TRAN <[email protected]> * Fix conflicts Co-authored-by: Yusuke Kuoka <[email protected]>
* chore(state): Append Api Versions flags to helm-diff Signed-off-by: Sergio Morales <[email protected]> * chore(state): Added unit test to state.flagsForDiff Signed-off-by: Sergio Morales <[email protected]> * chore(state): Check Helmstate values if ReleaseSpec values aren't set Signed-off-by: Sergio Morales <[email protected]>
Signed-off-by: yxxhero <[email protected]>
I've asked a few times by @yxxhero if he deserves a seat as a maintainer of the Helmfile project. Seeing the amount and the number of his recent contributions, and the nature of his contributions (add tests and fix bugs and CI issues, review PRs), I think he is in a relatively unique position compared to existing maintainers, and we can work better together! Signed-off-by: Yusuke Kuoka <[email protected]>
It turned out we lack some important information that is necessary to make it a real bug without guesswork. Signed-off-by: Yusuke Kuoka <[email protected]>
Probably this is the best we can currently offer. Any suggestions are welcomed though. Ref roboll/helmfile#2147 Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Yusuke Kuoka <[email protected]>
Signed-off-by: Stoned Elipot <[email protected]>
Signed-off-by: Stoned Elipot <[email protected]>
Minor documentation fixes
Signed-off-by: yxxhero <[email protected]>
Add proposals about two breaking changes before we cut Helmfile 1.0
Signed-off-by: ogugu (Riku Ogura) <[email protected]>
Fix deprecated chart in Getting Started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS REPOSITORY HAS BEEN MOVED.
Please see #2148 and submit your pull request to the new repository!