Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helmDefaults.repoForceUpdate and repositories[].forceUpdate configs. #1542

Closed
wants to merge 4 commits into from
Closed

Add helmDefaults.repoForceUpdate and repositories[].forceUpdate configs. #1542

wants to merge 4 commits into from

Conversation

wi1dcard
Copy link
Contributor

Add helmDefaults.repoForceUpdate and repositories[].forceUpdate in helmfile.yaml. With this PR, users can specify whether they'd like to enable --force-update globally, individually, or just leave it disabled (by default).

Related PRs or issues:

@wi1dcard
Copy link
Contributor Author

wi1dcard commented Oct 16, 2020

Found a problem here: helm seems not to update repos without the --force-update option, even though the URL specified in helmfile.yaml and existing helm repos are the same:

Adding repo stable https://kubernetes-charts.storage.googleapis.com/
"stable" already exists with the same configuration, skipping

Adding repo gitlab https://charts.gitlab.io
"gitlab" already exists with the same configuration, skipping

I don't see any good solution for now. Either we add the option --force-update (which could leave potential vulnerabilities), or don't add --force-update (which let helm just ignore adding or updating the repo if it already exists) is not the great option I think.

Probably we need to perform a helm repo update once helm repo adds are done, or otherwise we'd have to keep the --force-update option for now and apply it to Helm >=3.3.2 (this requires another hotfix PR, currently --force-update is only applied to Helm >=3.3.2 && <3.3.4, UPDATE: I've created another PR #1546 to fix the bug with Helm v3.3.4 first, please merge that PR then we can discuss more detail about how we should improve later on.)

Is there any better idea?

@wi1dcard
Copy link
Contributor Author

This PR should be able to pick up and implement now as Helm has added helm repo update <repo_name>. I'll rebase it to the latest later and finish it as soon as I'm available.

@yxxhero
Copy link
Contributor

yxxhero commented Jun 5, 2022

see: #2148

@wi1dcard wi1dcard closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants