Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Extend BuildManager for Environments #215

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

tunahanertekin
Copy link
Member

🌿 PR: Extend BuildManager for Environments

Description

Since the environments don't necessarily have a configured workspace, another scope of build is added named Path.

Closes #214

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How can it be tested?

Can be tested by a sample BuildManager:

apiVersion: robot.roboscale.io/v1alpha1
kind: BuildManager
metadata:
  name: test-bm
  namespace: test
  labels:
    robolaunch.io/target-robot: test
spec:
  steps:
  - command: |-
      echo "2" && sleep 2
    instances:
    - org-development-45679050
    name: first
    scope:
      scopeType: Path
      path: /home/robolaunch/workspaces
  - command: |-
      echo "3" && sleep 3
    instances:
    - org-development-45679050
    name: second
    scope:
      scopeType: Path
      path: /home/robolaunch/workspaces
  - command: |-
      echo "4" && sleep 15
    instances:
    - org-development-45679050
    name: third
    scope:
      scopeType: Path
      path: /home/robolaunch/workspaces
  - command: |-
      echo "5" && sleep 5
    instances:
    - org-development-45679050
    name: forth
    scope:
      scopeType: Path
      path: /home/robolaunch/workspaces

@tunahanertekin tunahanertekin added the enhancement New feature or request label Jan 19, 2024
@tunahanertekin tunahanertekin self-assigned this Jan 19, 2024
@tunahanertekin tunahanertekin linked an issue Jan 19, 2024 that may be closed by this pull request
@tunahanertekin tunahanertekin merged commit 9b95ecb into main Jan 19, 2024
1 check passed
@tunahanertekin tunahanertekin deleted the 214-refactoring-buildmanager branch January 19, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Manager CRDs
1 participant