Merge pull request #42 from vitri-ent/vitri/image-0.25 #180
Annotations
7 warnings
deref on an immutable reference:
src/features/image.rs#L110
warning: deref on an immutable reference
--> src/features/image.rs:110:2
|
110 | &*buffer
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
= note: `#[warn(clippy::borrow_deref_ref)]` on by default
help: if you would like to reborrow, try removing `&*`
|
110 | buffer
|
help: if you would like to deref, try using `&**`
|
110 | &**buffer
|
|
use of deprecated method `indexmap::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior.:
src/backend/window.rs#L297
warning: use of deprecated method `indexmap::IndexMap::<K, V, S>::remove`: `remove` disrupts the map order -- use `swap_remove` or `shift_remove` for explicit behavior.
--> src/backend/window.rs:297:44
|
297 | let removed = self.window_mut().overlays.remove(name.as_ref()).is_some();
| ^^^^^^
|
= note: `#[warn(deprecated)]` on by default
|
private item shadows public glob re-export:
src/lib.rs#L124
warning: private item shadows public glob re-export
--> src/lib.rs:124:1
|
124 | mod image;
| ^^^^^^^^^^
|
note: the name `image` in the type namespace is supposed to be publicly re-exported here
--> src/lib.rs:130:9
|
130 | pub use self::features::*;
| ^^^^^^^^^^^^^^^^^
note: but the private item here shadows it
--> src/lib.rs:124:1
|
124 | mod image;
| ^^^^^^^^^^
= note: `#[warn(hidden_glob_reexports)]` on by default
|
unused import: `map_buffer::map_buffer_mut`:
src/backend/util/mod.rs#L11
warning: unused import: `map_buffer::map_buffer_mut`
--> src/backend/util/mod.rs:11:9
|
11 | pub use map_buffer::map_buffer_mut;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `buffer::create_buffer_with_value`:
src/backend/util/mod.rs#L7
warning: unused import: `buffer::create_buffer_with_value`
--> src/backend/util/mod.rs:7:9
|
7 | pub use buffer::create_buffer_with_value;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Build and test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build and test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|