Ajustes phpstan

robmachado · Jun 12, 2024 · df3f4c7 · df3f4c7
1 parent 3ddaff7
commit df3f4c7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -30,8 +30,4 @@ parameters:
 			count: 1
 			path: src/Exception/DocumentsException.php
 
-		-
-			message: "#^Variable \\$tpEmis might not be defined\\.$#"
-			count: 1
-			path: src/Factories/Contingency.php
 
diff --git a/src/Common/Tools.php b/src/Common/Tools.php
@@ -60,9 +60,9 @@ class Tools
     public $tpAmb = 2;
     /**
      * contingency class
-     * @var Contingency
+     * @var Contingency|null
      */
-    public $contingency;
+    public $contingency = null;
     /**
      * soap class
      * @var ?SoapInterface
@@ -395,7 +395,7 @@ protected function isValid(string $version, string $body, string $method): bool
      */
     protected function checkContingencyForWebServices(string $service)
     {
-        $type = $this->contingency->type ?? null;
+        $type = !empty($this->contingency) ? $this->contingency->type : '';
         $mod = $this->modelo;
         if (!empty($type)) {
             if ($this->modelo == 65) {

diff --git a/src/Traits/TraitEPECNfce.php b/src/Traits/TraitEPECNfce.php
@@ -70,7 +70,7 @@ public function sefazEpecNfce(string &$xml, string $verAplic = null): string
         $dom->loadXML($xml);
         $infNFe = $dom->getElementsByTagName('infNFe')->item(0);
         $ide  = $dom->getElementsByTagName('ide')->item(0);
-        $tpEmis = (int) $ide->getElementsByTagName('tpEmis')->item(0)->nodeValue ?? 0;
+        $tpEmis = (int) $ide->getElementsByTagName('tpEmis')->item(0)->nodeValue;
         $dhCont = $ide->getElementsByTagName('dhCont')->item(0)->nodeValue ?? '';
         $xJust = $ide->getElementsByTagName('xJust')->item(0)->nodeValue ?? '';
         if ($tpEmis !== 4 || empty($dhCont) || empty($xJust)) {