Custom definitions for AudioAnalyzer. #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osyrisrblx
requested changes
Feb 23, 2024
include/customDefinitions.d.ts
Outdated
| @@ -868,6 +868,15 @@ interface SocialService extends Instance { | |||
| readonly GameInvitePromptClosed: RBXScriptSignal<(senderPlayer: Player, recipientIds: Array<number>) => void>; | |||
| } | |||
|
|
|||
| interface AudioAnalyzer extends Instance { | |||
| readonly Changed: RBXScriptSignal<(value: string) => void>; | |||
There was a problem hiding this comment.
Changed is actually from Instance.. but we intentionally omit it because it breaks inheritance.
You should try to use .GetPropertyChangedSignal() when possible.
If that doesn't work, there's a helper type called ChangedSignal for this purpose. Here's an example.
There was a problem hiding this comment.
we intentionally omit it because it breaks inheritance
To provide some more context:
Instance.Changedis typed as(string) -> voidNumberValue.Changedis typed as(number) -> void
These types conflict, so if we add both .Changed events, NumberValue cannot inherit from Instance without an error.
This applies to not just NumberValue, but several different -Value classes.
There was a problem hiding this comment.
Gotcha! I'll remove that real quick
osyrisrblx
requested changes
Feb 23, 2024
osyrisrblx
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom definitions for both
GetSpectrum()andChanged.