Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid emit of escaped new line character in template and literal strings #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

memothelemo
Copy link

Expected code in JavaScript:

console.log("Hello\
World!")

It should display: HelloWorld!

However, in roblox-ts, it emits an unexpected Luau code provided with the playground link for both literal and template strings:
https://roblox-ts.com/playground/#code/A4JwlgdgLgFARACQKYBsUHsA6AoA6ukFAEzgEog
https://roblox-ts.com/playground/#code/A4JwlgdgLgFABgCQKYBsUHsA6AoA6ukFAEzgEog

In this PR, when rendering Luau strings, it should strip off the excess \ if the escape character of a string is \n, so it should render Luau code something like this:

print("Hello\
World")

When using template literals, it should output like this:

print(`Hello
World`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant