Fix invalid emit of escaped new line character in template and literal strings #545
+23
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected code in JavaScript:
It should display:
HelloWorld!
However, in roblox-ts, it emits an unexpected Luau code provided with the playground link for both literal and template strings:
https://roblox-ts.com/playground/#code/A4JwlgdgLgFARACQKYBsUHsA6AoA6ukFAEzgEog
https://roblox-ts.com/playground/#code/A4JwlgdgLgFABgCQKYBsUHsA6AoA6ukFAEzgEog
In this PR, when rendering Luau strings, it should strip off the excess
\
if the escape character of a string is\n
, so it should render Luau code something like this:When using template literals, it should output like this: