Merge pull request #17 from robinmitra/update-category

Update 'movies' category key to be 'movie'.
robinmitra · Jun 23, 2019 · 3951fbc · 3951fbc
2 parents 38f5d5b + 2187824
commit 3951fbc
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gimme-quote",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "description": "A minimal desktop app for getting your dose of famous quotes.",
   "main": "main.js",
   "scripts": {

diff --git a/src/menu/components/category.js b/src/menu/components/category.js
@@ -36,11 +36,11 @@ const menuItem = new MenuItem({
       checked: isChecked('inspirational')
     },
     {
-      id: 'movies',
-      label: 'Movies',
+      id: 'movie',
+      label: 'Movie',
       type: 'checkbox',
       click: updateCategory,
-      checked: isChecked('movies')
+      checked: isChecked('movie')
     },
     {
       id: 'programming',

diff --git a/src/menu/menu.js b/src/menu/menu.js
@@ -17,11 +17,12 @@ const clearSchedule = () => clearInterval(intervalId);
 
 const showQuote = () => {
   const { quote, author, year } = quoteService.getRandom(store.getState().category);
+  if (!quote) return;
   (new Notification({
     title: author,
     body: quote,
     subtitle: year,
-    silent: store.getState().silent
+    silent: store.getState().silent,
   })).show();
 };
 

diff --git a/src/quoteService.js b/src/quoteService.js
@@ -36,7 +36,7 @@ exports.getRandom = categories => {
   }
   logger.log('Remaining quotes', remainingQuotes);
   const randomIndex = Math.floor(Math.random() * (remainingQuotes.length - 1));
-  const randomQuote = remainingQuotes[randomIndex];
+  const randomQuote = remainingQuotes[randomIndex] ? remainingQuotes[randomIndex] : {};
   remainingQuotes.splice(randomIndex, 1);
   logger.info('Returning random quote', randomQuote);
   return randomQuote;