-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging aio-libs/aiokafka into robinhood/aiokafka 1.1 #22
Open
forsberg
wants to merge
186
commits into
robinhood:1.1
Choose a base branch
from
forsberg:1.1-merge-aio-libs
base: 1.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheduled weekly dependency update for week 09
Add max_poll_interval_ms and rebalance_timeout_ms
remove unneeded test
Add Kerberos GSSAPI support
Scheduled weekly dependency update for week 10
* fix #590: kafka-python 2.0 support * fix #590: kafka-python 2.0 support
* Initialize SCRAM-SHA-256 and -512. Fixes #571 * Add test for SCRAM-SHA-256 * Add SCRAM-SHA-256 and -512 to sasl_mechanism * WIP: Add SCRAM-SHA to docker config * Add SCRAM-SHA to CHANGES.rst Co-authored-by: Taras Voinarovskyi <[email protected]>
* Fix transaction abort log * Add new kafka versions to CI Fix CI running issue with assignment None * capture_output not available for 3.6 and lower =( * Assignment can change during on_assigned callback. Thus we have to recheck if assignment is still active * Fix lint * Add proper handling of errors in Kafka server * Fix SASL tests * Fix API version in test
…595) * Add some missing test, that was in a different PR for some reason. Revert the kafka broker start timeout in tests to 60s * Add more verbosity to CI runs and limit logs for asyncio * Add limit to what tests do ACL cleanups apply * Made the test really simple, cause the ACL combinations just did not work out
Signed-off-by: Gabriel Linder <[email protected]>
* Fix issue #536 for race condition between metadata update and subscription change * Fix test * Add some debug prints * Rework the patch to properly reassign partitions * Fix lint
…ad of retrying on commit (#611)
because the command fails on the debug file information gathering step. Skip debug package macro is inserted as the first element in the spec file, due to importance of order of definitions
* Wrap up CHANGES for release * Fix unrelated line
Fixes: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release!
* hotfix/ memory leak in comsumer getmany * hotfix/ Added changes in change log * hotfix/ Fixed case where pending future set is empty * hotfix/ renamed pending future variable
* added OAUTHBEARER as an authorization method * fixed flake errors * made AbstractTokenProvider to async friendly * updated CHANGES * changed oauth assert to ValueError * updated CHANGES * offered our indenpendent AbastractTokenProvider * avoided calling extensions multiple times * updated CHANGES * Consumer memory leak in idle state (#629) * hotfix/ memory leak in comsumer getmany * hotfix/ Added changes in change log * hotfix/ Fixed case where pending future set is empty * hotfix/ renamed pending future variable * updated CHANGES Co-authored-by: Andy Luo <[email protected]> Co-authored-by: Rajat Singh <[email protected]>
* Try out GitHub Actions as Travis alternative * Add apt requirements * Only do 1 python on sanity` * Use develop version of krb... * For now go with python 3.7 * Try out all platforms * Try out separate run for windows * Check windows functions * Fix snappy wlh * Fix cache * Windows expects windows container, not linux ones. Not sure how to run linux containers on windows-latest runner yet * Try to add macosx tests * Return gssapi and ability to run tests without C extensions too * Use declarative environment and run all tests on MacOS * Macos runner does not seem to have docker installed at all, a shame. Running only unit tests for now * Try out linux full run * Fix linux tests and provide proper cache dir for PIP * Try full matrix * Enlarge timeout for GithubActions * Make matrix not fail-fast * Add upload to codecov * Make sure we generate XML coverage * For now disable travis.yaml * Try to cat files to understand why coverage lines don't match * Try to checkout head for windows build * Apply HEAD checkout to linux and mac builds to make sure coverage is consistently generated * Temporary set build trigger to push, not PR to check if builds on direct master branch would work * Return master PR build instead of push * Add asyncio debug for windows and mac cases to debug any KQueue or Proreactor issues * Install package on Publish correctly. Bump version to 0.6.1.dev0 for deploy testing * Try out multi-linux wheel builds * Add requirements-cython.txt to git * Change test command for wheel build * Add another event to build action for faster debugging * Add pytest installation to CIWheel build * Raise verbosity for build * Add zlib dependancy * Try to use Windows compliant command * Debug import error for wheel * More debug * Print lib address * Add pwd to test command * Try using `pytest` instead of `python -m` * Try to use `--import-mode=importlib` to avoid import problems * `importlib` mode not released yet, try prepend * Try to delete __init__py in tests * Try to use proper makefile with tests * Return __init__.py and try another method * Invalid env variable * Try without tests, as it causes some problems to properly run them using cibuildwheel * Try to add unit tests run after wheel build * Try to fix test errors for wheels * Try again to fix wheel tests * Cleanup Publish workflow debug changes * Try to force color output to github actions
* Update flake8 from 3.7.9 to 3.8.3 * Update flake8 from 3.7.9 to 3.8.3 * Update pytest from 5.3.5 to 5.4.3 * Update pytest from 5.3.5 to 5.4.3 * Update pytest-cov from 2.8.1 to 2.10.0 * Update pytest-cov from 2.8.1 to 2.10.0 * Update docker from 4.2.0 to 4.2.1 * Update docker from 4.2.0 to 4.2.1 * Update lz4 from 2.2.1 to 3.1.0 * Update lz4 from 2.2.1 to 3.1.0 * Update pygments from 2.5.2 to 2.6.1 * Update gssapi from 1.6.1 to 1.6.6 * Update cython from 0.29.19 to 0.29.20 * Update diff-cover from 2.6.0 to 3.0.1 * Update sphinx from 2.4.1 to 3.1.1 * Update sphinxcontrib-spelling from 4.3.0 to 5.1.1 * Update requirements-ci.txt * Update requirements-ci.txt Co-authored-by: Taras Voinarovskyi <[email protected]>
… support. (#638) * Refactored util.py and structs.py to pass mypy, format using blake and isort. Having automatic code formatting helps with consistent styling across the project, thus want to encorporate it part after part. * Add config.cfg and stubs for Kafka library * Flake should apply for the whole project, not only for formatted areas * Fix tests * Added dataclasses and async generator support for older python's
This is robinhood-aiokafka 1.1.6 with changes from aio-lib/aiokafka up to commit 84e2a98 merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of aio-libs/aiokafka into robinhood/aiokafka 1.1, made to the best of my abiliites - and that's meant as a warning, as it was a pretty complex merge with lot's of conflicts, and I'm not very familiar with this library.
Nevertheless, I made this attempt as I really needed the SASL-SCRAM-256/512 authentication support. I have got it working with faust with a few changes (See my 1.10-scram-sha-sasl-mechanism branch.
Is robinhood/aiokafka really needed anymore? It's unclear to me why it was forked, perhaps what was missing has now been added to aio-libs/aiokafka so the extra work can be avoided?