Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang tidy pr #3

Closed
wants to merge 11 commits into from
Closed

Clang tidy pr #3

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cb992b1
try class naming
robin88chen Nov 18, 2024
a63c304
change tidy
robin88chen Nov 18, 2024
2e882d6
test remove
robin88chen Nov 18, 2024
ef6845d
add tidy
robin88chen Nov 18, 2024
4669934
remove build, super lint action on pr
robin88chen Nov 18, 2024
0b9f040
fix one issue
robin88chen Nov 18, 2024
7f0362a
fix tidy
robin88chen Nov 18, 2024
d42d127
for member
robin88chen Nov 18, 2024
f2ad533
other naming
robin88chen Nov 18, 2024
f5a4842
test
robin88chen Nov 18, 2024
28ff62c
test
robin88chen Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions StdAny/StdAny/.clang-tidy → .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,4 +184,30 @@ CheckOptions:
value: ''
- key: readability-identifier-naming.ClassCase
value: CamelCase
- key: readability-identifier-naming.ClassMemberPrefix
value: s_
- key: readability-identifier-naming.ClassMemberCase
value: camelBack
- key: readability-identifier-naming.MemberPrefix
value: m_
- key: readability-identifier-naming.MemberCase
value: camelBack
- key: readability-identifier-naming.ParameterCase
value: lower_case
- key: readability-identifier-naming.MethodCase
value: camelBack
- key: readability-identifier-naming.ConstantParameterCase
value: lower_case
- key: readability-identifier-naming.EnumCase
value: CamelCase
- key: readability-identifier-naming.EnumConstantCase
value: camelBack
- key: readability-identifier-naming.NamespaceCase
value: CamelCase
- key: readability-identifier-naming.VariableCase
value: lower_case
- key: readability-identifier-naming.MacroDefinitionCase
value: UPPER_CASE
- key: readability-identifier-naming.FunctionCase
value: camelBack

4 changes: 2 additions & 2 deletions .github/workflows/msbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ name: 🧩 MSBuild
on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
#pull_request:
# branches: [ "main" ]

env:
# Path to the solution file relative to the root of the project.
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/super-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ name: Lint Code Base
on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]
#pull_request:
# branches: [ "main" ]
jobs:
run-lint:
runs-on: ubuntu-latest
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/tidy-clang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@ name: Clang Tidy
on:
push:
branches: [ "main" ]
paths: ['**.c', '**.cpp', '**.h', '**.hpp', '**.cxx', '**.hxx', '**.cc', '**.hh', '**CMakeLists.txt', 'meson.build', '**.cmake']
paths: ['**.c', '**.cpp', '**.h', '**.hpp', '**.cxx', '**.hxx', '**.cc', '**.hh', '**CMakeLists.txt', '**.cmake']
pull_request:
branches: [ "main" ]
paths: ['**.c', '**.cpp', '**.h', '**.hpp', '**.cxx', '**.hxx', '**.cc', '**.hh', '**CMakeLists.txt', '**.cmake']
permissions:
contents: read
pull-requests: write
jobs:
run-lint:
runs-on: ubuntu-latest
Expand All @@ -31,5 +35,9 @@ jobs:
tidy-checks: '' # Use .clang-tidy config file
extra-args: '-std=c++17'
verbosity: debug
tidy-review: true
# only 'update' a single comment in a pull request thread.
#thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
- name: Fail fast?!
if: steps.linter.outputs.checks-failed > 0
run: exit 1
Loading
Loading