Clang tidy pr

StdAny/StdAny/.clang-tidy → .clang-tidy

@@ -184,4 +184,16 @@ CheckOptions:
     value:           ''
   - key:             readability-identifier-naming.ClassCase
     value:           CamelCase
+  - key:             readability-identifier-naming.ClassMemberPrefix
+    value:           s_
+  - key:             readability-identifier-naming.ClassMemberCase
+    value:           camelBack
+  - key:             readability-identifier-naming.MemberPrefix
+    value:           p_
+  - key:             readability-identifier-naming.MemberCase
+    value:           camelBack
+  - key:             readability-identifier-naming.ParameterCase
+    value:           lower_case
+  - key:             readability-identifier-naming.MethodCase
+    value:           camelBack
 

.github/workflows/msbuild.yml

@@ -8,8 +8,8 @@ name: 🧩 MSBuild
 on:
   push:
     branches: [ "main" ]
-  pull_request:
-    branches: [ "main" ]
+  #pull_request:
+  #  branches: [ "main" ]
 
 env:
   # Path to the solution file relative to the root of the project.

.github/workflows/super-linter.yml

@@ -9,8 +9,8 @@ name: Lint Code Base
 on:
   push:
     branches: [ "main" ]
-  pull_request:
-    branches: [ "main" ]
+  #pull_request:
+  #  branches: [ "main" ]
 jobs:
   run-lint:
     runs-on: ubuntu-latest

.github/workflows/tidy-clang.yml

@@ -9,9 +9,13 @@ name: Clang Tidy
 on:
   push:
     branches: [ "main" ]
-    paths: ['**.c', '**.cpp', '**.h', '**.hpp', '**.cxx', '**.hxx', '**.cc', '**.hh', '**CMakeLists.txt', 'meson.build', '**.cmake']
+    paths: ['**.c', '**.cpp', '**.h', '**.hpp', '**.cxx', '**.hxx', '**.cc', '**.hh', '**CMakeLists.txt', '**.cmake']
   pull_request:
     branches: [ "main" ]
+    paths: ['**.c', '**.cpp', '**.h', '**.hpp', '**.cxx', '**.hxx', '**.cc', '**.hh', '**CMakeLists.txt', '**.cmake']
+permissions:
+  contents: read
+  pull-requests: write
 jobs:
   run-lint:
     runs-on: ubuntu-latest
@@ -31,5 +35,9 @@ jobs:
           tidy-checks: '' # Use .clang-tidy config file
           extra-args: '-std=c++17'
           verbosity: debug
+          tidy-review: true
           # only 'update' a single comment in a pull request thread.
           #thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
+      - name: Fail fast?!
+        if: steps.linter.outputs.checks-failed > 0
+        run: exit 1

StdAny/StdAny/StdAny.cpp

@@ -8,7 +8,7 @@
 #include <unordered_map>
 
 static int s_counter = 0;
 class obj
 {
 public:
     obj() : m_a{ s_counter++ }
@@ -20,17 +20,20 @@
         m_a = o.m_a;
         std::cout << "obj " << m_a << " copied. \n";
     }
-    
+
     ~obj()
     {
         std::cout << " obj " << m_a << " destruct. \n";
     }
 
+    int& a() { return m_a; }
+private:
     int m_a;
+    static int m_b;
 };
 
 
 class bank
 {
 public:
     bank()
@@ -41,35 +44,35 @@
     {
         std::cout << "bank destruct. \n";
     }
-    void set(const std::any& a)  
+    void set(const std::any& aB)
     {
         std::cout << "set bank data. \n";
-        m_data = a;
+        m_data = aB;
     }
 
     //template <class T> void set_org(T a) /// 如果參數type 直接寫 T, 會複製傳進來
     template <class T> void set_org(const T& a) /// 這樣是物件參考，參數不會複製
     {
         std::cout << "set bank org data. \n";
         m_data = a; /// 這裡會複製
     }
 
-    const std::any& get()  
+    const std::any& get()
     {
         std::cout << "get bank data. \n";
         return m_data;
     }
     template <class T> T get_org()
     {
         std::cout << "get bank org data. \n";
         return std::any_cast<T>(m_data);
     }
     template <class T> std::optional<T> get_opt()
     {
         std::cout << "get bank opt data. \n";
         return std::any_cast<T>(m_data);
     }
     template <class T> std::optional<std::reference_wrapper<T>> get_opt_ref()
     {
         std::cout << "get bank opt data. \n";
         //return std::any_cast<T>(m_data); /// 這樣編譯不過, C2440
@@ -77,6 +80,7 @@
         return std::ref(m_data);
     }
     std::any m_data;
+    std::vector<obj> m_org_data;
     //const std::any& m_data; /// 不能用
 };
 using func_any = std::function<std::any(const std::string&)>;
@@ -103,7 +107,7 @@
     //auto ob = std::any_cast<std::vector<obj>>(std::cref(a));  /// 這樣不能轉
     auto ob = std::any_cast<std::reference_wrapper<std::vector<obj>>>(a1);  /// by reference 要這樣轉
     //ob[3].m_a = -1;  // by value
-    ob.get()[3].m_a = -1; // by reference, 要從 wrapper 裡 get 出來
+    ob.get()[3].a() = -1; // by reference, 要從 wrapper 裡 get 出來
     std::cout << "func return\n";  /// 參數跟著內部變數一起解構
 }
 
@@ -153,7 +157,7 @@
         //auto ov2 = b->get_org<const std::vector<obj>&>();  /// 有複製, auto 不是引用
         //auto& ov2 = b->get_org<const std::vector<obj>&>();  /// 沒有複製
         auto& ov2 = b->get_org<std::vector<obj>&>();  /// 沒有複製, 可以取出來改
-        ov2[8].m_a = -23;
+        ov2[8].a() = -23;
         std::cout << "end block\n";
     }
     /// 結論是, any 是 value, 建構或指定時會複製一份; 取值時並不會特別複製一份

StdAny/StdAny/StdAny.vcxproj

@@ -85,6 +85,7 @@
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
     <LinkIncremental>false</LinkIncremental>
     <OutDir>$(SolutionDir)$(PlatformTarget)\$(Configuration)\</OutDir>
+    <EnableClangTidyCodeAnalysis>true</EnableClangTidyCodeAnalysis>
   </PropertyGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <ClCompile>