Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data.Marshaler #19

Merged
merged 1 commit into from
Jan 18, 2015
Merged

Add data.Marshaler #19

merged 1 commit into from
Jan 18, 2015

Conversation

ttacon
Copy link
Contributor

@ttacon ttacon commented Jan 17, 2015

This just adds the interface and a simple test case (the exact issue from issue #18 ).

@@ -103,3 +108,9 @@ func (c StructOptions) Data(obj interface{}) Map {
}
return Map(m)
}

// Marshaler is the interface implemented by entities that can marshal
// themselves into a data.Map.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Map/Value/

@robfig
Copy link
Owner

robfig commented Jan 17, 2015

nice, thanks

@ttacon
Copy link
Contributor Author

ttacon commented Jan 18, 2015

There's always something that slips my attention :P

@robfig
Copy link
Owner

robfig commented Jan 18, 2015

LGTM :)

robfig added a commit that referenced this pull request Jan 18, 2015
@robfig robfig merged commit e8bc360 into robfig:master Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants