Remove self-dependency of crates in development #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rten crate had a dependency on itself in development in order to enable additional features. This worked when building, but appeared to prevent rust analyzer from working properly in the rten-examples crate. See also rust-lang/cargo#2911.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rten and rten-generate crates had a self-dependency used to enable features when running tests. This caused rust-analyzer to complain about cyclic dependencies when running
rust-analyzer diagnosticsand it seems that there might be some issues in Cargo (see rust-lang/cargo#2911) but I haven't read the whole thread yet.See also rust-lang/rust-analyzer#14167.