Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to gwemopt v0.2, and latest winterapi #73

Merged
merged 7 commits into from
May 28, 2024
Merged

Swap to gwemopt v0.2, and latest winterapi #73

merged 7 commits into from
May 28, 2024

Conversation

robertdstein
Copy link
Owner

This PR abandons the pinned gwemopt submodule, and instead uses v0.2.2 as a standard dependency.

It abandons poetry (so much trouble for such little gain).

It moves to pydantic v2, enabling us to use the latest winterapi (fix #72).

It bumps the version to v1.0.0

@robertdstein robertdstein enabled auto-merge (squash) May 28, 2024 20:30
@coveralls
Copy link

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9276222194

Details

  • 35 of 41 (85.37%) changed or added relevant lines in 2 files are covered.
  • 29 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-13.9%) to 47.761%

Changes Missing Coverage Covered Lines Changed/Added Lines %
snipergw/model.py 23 29 79.31%
Files with Coverage Reduction New Missed Lines %
snipergw/submit/init.py 2 0.0%
snipergw/run.py 8 0.0%
snipergw/submit/ztf.py 9 0.0%
snipergw/submit/winter.py 10 0.0%
Totals Coverage Status
Change from base Build 6714002601: -13.9%
Covered Lines: 160
Relevant Lines: 335

💛 - Coveralls

@robertdstein robertdstein merged commit 66d20e5 into main May 28, 2024
7 checks passed
@robertdstein robertdstein deleted the hotfix branch May 28, 2024 20:59
@robertdstein robertdstein mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG winterapi version is old, causing incompatibility with stored programs
2 participants