Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience adapter class for reading a single DS18X20 sensor #15

Closed
wants to merge 1 commit into from

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Nov 18, 2019

Dear Robert,

this reimplements some bits of your original improved driver from pycom/pycom-libraries#62 using a minimal adapter class.

This might resolve #11 in a non-intrusive way. It separates concerns and by adding it through a distinct file, the code can be optionally imported by anyone who needs this feature.

If you still like to see that convenience feature, you might want to have this available. If not, feel free to close the PR right away.

With kind regards,
Andreas.

@robert-hh
Copy link
Owner

robert-hh commented Nov 18, 2019

Does not work like that, since there is not self.roms stored in the DS18X20 driver. I had to add an init which get the list of roms. Also, init of the DS18X20 class had to be called.
Edit: So I will not merge that PR, but do a manual copy & paste. Thanks

@amotl
Copy link
Contributor Author

amotl commented Nov 18, 2019

Does not work like that, since there is not self.roms stored in the DS18X20 driver.

Oops, I missed that detail. The adapter class was thought to be a kind of sketch, sorry that I forgot to outline this appropriately and thanks again for taking care about the details.

@amotl amotl closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convenience for reading a single DS18X20 sensor
2 participants