Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precise frequency mode to BuffrGlitch #160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arseniiv
Copy link

My implementation of what was proposed in #138.

This is code that wasn’t tested nor built locally so I lay my hopes on CI making sure if it builds at all. Hopefully it should because I didn’t need to use depths of Rust I’m not accustomed with.

Also I tried to write the code according to style I was able to see in this project but if there are parts that should be reformatted, just say so, of course.

Hopefully it does what I intended it to do. And the default behavior should be the old one, the new mode is opt-in.

Also I wasn’t satisfied very much with the mode change applying only on note-on events but that was the easiest way to go without wreaking havoc on the current API, and also it seems pretty reasonable not to mess with a currently played note, and pretty reasonable that the user shouldn’t change the mode back and forth at all.

Well, and also my description in the changelog is probably not very instructive; I’m open for suggestions.

@arseniiv
Copy link
Author

arseniiv commented Sep 1, 2024

@robbert-vdh What can I do for the checks to run? Are they still correctly configured? Didn’t want to bother you before it’ll be clear if this really works but it seems I need to, as some time has already passed with no change. 🙂 And I guess take a look at the code then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant