[WIP] update to the latest iced_baseview (iced 0.10) #112
Conversation
ilya-epifanov
force-pushed
the
iced-0.10
branch
from
20f68b8
to
f3ecd9d
Compare
ilya-epifanov
changed the title
ilya-epifanov
force-pushed
the
iced-0.10
branch
from
f3ecd9d
to
6dd08e4
Compare
| @@ -14,4 +14,4 @@ quote = "1.0" | |||
| proc-macro2 = "1.0" | |||
|
|
|||
| [dev-dependencies] | |||
| nih_plug = { path = ".." } | |||
| nih_plug = { path = "..", default-features = false } | |||
There was a problem hiding this comment.
otherwise it's impossible to opt out of default features in a binary
ilya-epifanov
force-pushed
the
iced-0.10
branch
from
6dd08e4
to
bbb5c09
Compare
|
@robbert-vdh I'd like some input from you on this PR. |
There was a problem hiding this comment.
Thanks a lot for working on this! I spent a couple hours doing this a couple months ago, and then promptly stopped when I got frustrated with the whole architecture halfway through porting ParamSlider.
I'll borrow the resolver and default features changes on the master branch right now. Take your time finishing this PR. Or if someone else wants to chip in, feel free!
| @@ -11,6 +11,8 @@ description = "A simple but modern API-agnostic audio plugin framework" | |||
| repository = "https://github.com/robbert-vdh/nih-plug" | |||
|
|
|||
| [workspace] | |||
| resolver = "2" | |||
There was a problem hiding this comment.
Nice drive by fix! Meant to add this for a while (would be nice if it was inferred from the edition of the workspace members) but I kept forgetting about it.
| @@ -14,4 +14,4 @@ quote = "1.0" | |||
| proc-macro2 = "1.0" | |||
|
|
|||
| [dev-dependencies] | |||
| nih_plug = { path = ".." } | |||
| nih_plug = { path = "..", default-features = false } | |||
| #[cfg(not(feature = "opengl"))] | ||
| gl_config: None, | ||
| // #[cfg(not(feature = "opengl"))] | ||
| // gl_config: None, |
There was a problem hiding this comment.
If this is not needed anymore then the whole section including the comment can be removed.
No description provided.