Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review changes #38

Merged
merged 20 commits into from
Mar 22, 2021
Merged

JOSS review changes #38

merged 20 commits into from
Mar 22, 2021

Conversation

robashaw
Copy link
Owner

@robashaw robashaw commented Mar 6, 2021

This addresses issues #34, #35, #36, and #37 created as part of the JOSS review process. It contains the JOSS paper, along with the following changes:

  • code of conduct and architecture files
  • documentation of auxiliary python scripts
  • default build Release (with optimizations turned on)
  • a standalone example, separate from the testing suite

The python bindings mentioned in issue #8 are being handled separately.

This branch will be merged at the end of the review process.

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #38 (035a3de) into master (d53a409) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   89.71%   89.80%   +0.09%     
==========================================
  Files          19       19              
  Lines        1954     1952       -2     
==========================================
  Hits         1753     1753              
+ Misses        201      199       -2     
Impacted Files Coverage Δ
include/libecpint/ecpint.hpp 100.00% <ø> (ø)
src/lib/api.cpp 81.27% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d53a409...035a3de. Read the comment docs.

@felipeZ
Copy link

felipeZ commented Mar 19, 2021

Great job!

@robashaw robashaw merged commit f40bbc2 into master Mar 22, 2021
@robashaw robashaw deleted the joss branch March 22, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants