Add AppService trait and use it to implement the HTTP service
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an `AppService` trait to allow consumers to define custom services that will be run as tokio tasks. This is similar (I believe) to Laraval's `Provider` concept. Use the `AppService` trait to add an HTTP server using Axum instead of putting http/axum specific methods directly on the `App` trait - This will help with #9 (and we may be able to resolve it) - This will resolve #19
- Allow consumers to register services using the `ServiceRegistry`. - Update the config structure to add a `service` config, under which the `http` service config belongs, along with future services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
AppServicetrait to allow consumers to define custom services that will be run as tokio tasks. This is similar (I believe) to Laraval'sProviderconcept.Use the
AppServicetrait to add an HTTP server using Axum instead of putting http/axum specific methods directly on theApptrait