feat: Support sidekiq balance strategy and dedicated queues #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks will fail until the following commits are merged into |
spencewenski
force-pushed
the
dedicated-queue-workers
branch
from
0814b83 to
4204cad
Compare
Add support for the `BalanceStrategy` config from `rusty-sidekiq` and default to `BalanceStrategy#RoundRobin` to ensure all queues have a chance to have their jobs run by default. Also add support for dedicated queues via the `service.sidekiq.queue-config` field. Queues listed in this field will run with a dedicated set of workers (equal to the `num-workers` sub-field for each queue).
spencewenski
force-pushed
the
dedicated-queue-workers
branch
from
4204cad to
2e175e0
Compare
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the
BalanceStrategyconfig fromrusty-sidekiqand default toBalanceStrategy#RoundRobinto ensure all queues have a chance to have their jobs run by default.Also add support for dedicated queues via the
service.sidekiq.queue-configfield. Queues listed in this field will run with a dedicated set of workers (equal to thenum-workerssub-field for each queue).Closes #540