Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config to specify the domain where the service is hosted #490

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

spencewenski
Copy link
Member

Also, add some parse errors to the Roadster Error enum.

Also, add some parse errors to the Roadster Error enum.
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.

Project coverage is 42.76%. Comparing base (0ac777b) to head (e39f716).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/error/parse.rs 0.00% 6 Missing ⚠️
src/config/service/http/mod.rs 0.00% 5 Missing ⚠️
src/config/service/common/address.rs 83.33% 1 Missing ⚠️
src/config/service/grpc/mod.rs 88.88% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/config/mod.rs 35.33% <100.00%> (+3.05%) ⬆️
src/error/mod.rs 0.00% <ø> (ø)
src/config/service/common/address.rs 46.15% <83.33%> (+37.06%) ⬆️
src/config/service/grpc/mod.rs 91.66% <88.88%> (-8.34%) ⬇️
src/config/service/http/mod.rs 64.70% <0.00%> (-26.97%) ⬇️
src/error/parse.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ac777b...e39f716. Read the comment docs.

@spencewenski spencewenski merged commit ef5294d into main Oct 28, 2024
19 checks passed
@spencewenski spencewenski deleted the url-scheme branch October 28, 2024 01:26
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
spencewenski added a commit that referenced this pull request Oct 29, 2024
## 🤖 New release
* `roadster`: 0.6.15 -> 0.6.16 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.6.16](roadster-v0.6.15...roadster-v0.6.16)
- 2024-10-28

### Added

- Add config to specify the domain where the service is hosted
([#490](#490))

### Other

- Remove resolved advisory from deny ignore list
([#487](#487))
- Use `unimplemented!()` in hidden doc example instead of `todo!()`
([#483](#483))
- Remove a todo comment that was completed
([#482](#482))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Spencer Ferris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant