feat: Add AnyInitializer to minimize boilerplate for initializers
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a consumer wants to initialize the Axum Router in a way that's not already supported by Roadster, they need to implement the `Initializer` trait, which is extra boilerplate that could be annoying. Add `AnyInitializer` struct that implements the `Initializer` trait, so consumers just need to provide the name of the initializer and the logic to build/configure the Axum Router. Note: This PR also contains a breaking change to `AnyMiddleware`. However, since this was just released a few hours ago, I doubt anyone is using it yet, so it should be relatively safe to just release the breaking change in a patch update. Closes #473
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a consumer wants to initialize the Axum Router in a way that's not already supported by Roadster, they need to implement the
Initializertrait, which is extra boilerplate that could be annoying.Add
AnyInitializerstruct that implements theInitializertrait, so consumers just need to provide the name of the initializer and the logic to build/configure the Axum Router.Note: This PR also contains a breaking change toActually, it looks likeAnyMiddleware. However, since this was just released a few hours ago, I doubt anyone is using it yet, so it should be relatively safe to just release the breaking change in a patch update.AnyMiddlewarewasn't released before this PR was merged, so no api-breaking changes were released.Closes #473