Add CLI commands to run DB migrations #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prompted a refactor of the `RunCommand` trait to add `A: App` and pass the `App` instance as a parameter in `RunCommand::run`. This is possibly useful for other commands, and potentially for the consumer's custom commands as well. Another benefit of passing the `App` instance as a parameter is it simplifies the syntax for specifying the `A` generic argument. #41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prompted a refactor of the
RunCommandtrait to addA: Appand pass theAppinstance as a parameter inRunCommand::run. This is possibly useful for other commands, and potentially for the consumer's custom commands as well. Another benefit of passing theAppinstance as a parameter is it simplifies the syntax for specifying theAgeneric argument.#41