fix: Correctly add the ApiRouter to the HTTP service's ApiRouter
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `HttpServiceBuilder#api_router` method is incorrectly adding the provided `ApiRouter` to the normal axum `Router`. This means the routes defined in the provided `ApiRouter` will not show up in the generated OpenAPI schema. Fix the method to correctly merge the provided `ApiRouter` with the `HttpServiceBuilder`'s `ApiRouter`.
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
Merged
spencewenski
pushed a commit
that referenced
this pull request
Jul 7, 2024
## 🤖 New release * `roadster`: 0.5.3 -> 0.5.4 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.5.4](roadster-v0.5.3...roadster-v0.5.4) - 2024-07-07 ### Added - Add method to prepare the app separately from running it ([#270](#270)) ### Fixed - Correctly add the `ApiRouter` to the HTTP service's `ApiRouter` ([#273](#273)) ### Other - Fixes for default openapi docs ([#271](#271)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HttpServiceBuilder#api_routermethod is incorrectly adding the providedApiRouterto the normal axumRouter. This means the routes defined in the providedApiRouterwill not show up in the generated OpenAPI schema.Fix the method to correctly merge the provided
ApiRouterwith theHttpServiceBuilder'sApiRouter.