feat: Move sidekiq "stale cleanup" to new before_run service method
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
In order to allow handling CLI commands with services without requiring the sidkiq redis connection to be available, we need to move the "stale cleanup" behavior out of the "build" method so that the service can be built without needing to access redis. This is accomplished by adding a new `AppService::before_run` trait method, which is run after all the services are built and before any of the services are run. The sidekiq service's "stale cleanup" behavior is now implemented in this trait method. This PR also updates the health check API to run the db and redis checks in parallel. Closes #238
spencewenski
force-pushed
the
gh-238-move-stale-cleanup
branch
from
473d805 to
4c3d18e
Compare
Merged
spencewenski
pushed a commit
that referenced
this pull request
Jun 23, 2024
## 🤖 New release * `roadster`: 0.3.3 -> 0.3.4 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.4](roadster-v0.3.3...roadster-v0.3.4) - 2024-06-23 ### Added - Add health checks to run before starting services ([#242](#242)) - Add `From` impl to convert db config to ConnectOptions ([#240](#240)) - Move sidekiq "stale cleanup" to new `before_run` service method ([#239](#239)) ### Other - Add dependabot config to update github actions weekly ([#243](#243)) - Update READMEs to use `__` as the env var separator instead of `.` - Update list of UI frameworks in readme - Set up `cargo deny` </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow handling CLI commands with services without requiring the sidkiq redis connection to be available, we need to move the "stale cleanup" behavior out of the "build" method so that the service can be built without needing to access redis.
This is accomplished by adding a new
AppService::before_runtrait method, which is run after all the services are built and before any of the services are run. The sidekiq service's "stale cleanup" behavior is now implemented in this trait method.This PR also updates the health check API to run the db and redis checks in parallel.
Closes #238