fix: Invalid env var separator on bash #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
We use `.` as the env var separator in order to differentiate between the prefix and different levels of the config vs individual config field names (which would be in UPPER_SNAKE_CASE). However, `.` is not a valid bash identifier, so we need to use something different. Switch to using a double underscore (`__`) instead of `.`. This way, we can support bash and still be able to differentiate between the prefix and different levels of the config vs individual config field names. Closes: #219
spencewenski
force-pushed
the
219-invalid-env-var-separator
branch
from
04deb91 to
8debc78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
.as the env var separator in order to differentiate between the prefix and different levels of the config vs individual config field names (which would be in UPPER_SNAKE_CASE). However,.is not a valid bash identifier, so we need to use something different.Switch to using a double underscore (
__) instead of.. This way, we can support bash and still be able to differentiate between the prefix and different levels of the config vs individual config field names.Note: we will continue to allow using
.until the next breaking semver release (0.4)Closes: #219