Provide config defaults via config files #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we’re using the config crate, it probably makes more sense (and would be cleaner) to provide the defaults via a config file. In comparison, our [current approach](https://github.com/roadster-rs/roadster/blob/2aef4f0d25b87200370fe8f578b4c411117c3b6e/src/config/service/http/middleware.rs#L254) of deserializing to an intermediate partial struct with customer deserializers is pretty convoluted and requires a lot of boilerplate. The downside of this approach is we need to hard-code the default middleware/initializer priorities in the config file vs setting them dynamically. However, I think this is a decent trade off to get rid of the boilerplate of our original approach. A test was added to check that the priorities don't change by accident.
|
There's technically a public API breaking change (hence the semver check failure). However, we don't have any dependencies yet, and the removed structs should have never been made in the first place, so we will release the changes in 0.2.x instead of 0.3. |
Codecov ReportAttention: Patch coverage is
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180