Use automock to mock traits instead of the mock! macro #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple places we were using `mock!` instead of `automock`. IIRC this was because `automock` wasn't working for `async_trait` traits; however, after reading the `mockall` docs, I found that `automock` needs to be placed _before_ `async_trait` in order for it to work. Also, specifically for the `App` trait, I just learned how to specify associated types with `automock`. With this new knowledge, we can replace a couple manual `mock!` impls with `automock`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple places we were using
mock!instead ofautomock. IIRC this was becauseautomockwasn't working forasync_traittraits; however, after reading themockalldocs, I found thatautomockneeds to be placed beforeasync_traitin order for it to work. Also, specifically for theApptrait, I just learned how to specify associated types withautomock.With this new knowledge, we can replace a couple manual
mock!impls withautomock.