Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable coverage on nightly and add coverage(off) annotations #122

Merged
merged 4 commits into from
May 15, 2024

Conversation

spencewenski
Copy link
Member

@spencewenski spencewenski commented May 15, 2024

Note that ignoring coverage for tests will reduce the overall coverage percentage.

Add the `coverage(off)` annotation to all tests. There are some caveats
with this attribute:

- It doesn't seem to work be working for `rstest` tests
- It needs to be added to each test method; it can't be added to the
  test modules

Note: this annotation isn't needed for tests located in a top-level
`tests` directory.

Note: I tried using the https://github.com/taiki-e/coverage-helper
crate, but it didn't seem to work
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@spencewenski spencewenski merged commit 55340ff into main May 15, 2024
5 of 6 checks passed
@spencewenski spencewenski deleted the coverage-nightly branch May 15, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant