Add methods to AppContext instead of direct field access #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it slightly more ergonomic to contain the app context state with an "inner" type that's wrapped by an Arc. This also allows consumers to disallow direct access to specific fields using clippy's [disallowed-methods](https://rust-lang.github.io/rust-clippy/master/index.html#/disallowed_methods) lint. This is useful, for example, if consumers want to provide their own method for accessing the DB that performs some logic before/after the DB operations, e.g. for implementing RLS.
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it slightly more ergonomic to contain the app context state with an "inner" type that's wrapped by an Arc.
This also allows consumers to disallow direct access to specific fields using clippy's
disallowed-methods lint. This is useful, for example, if consumers want to provide their own method for accessing the DB that performs some logic before/after the DB operations, e.g. for implementing RLS.