-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor basic crypto to not use raw pointers. #2303
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2303 +/- ##
==========================================
+ Coverage 84.88% 84.90% +0.02%
==========================================
Files 114 114
Lines 22784 22789 +5
==========================================
+ Hits 19340 19350 +10
+ Misses 3444 3439 -5 ☔ View full report in Codecov by Sentry. |
c901c3f
to
16137d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Megimg with 2 approvals |
This PR continues work, done in PR #2292 . Unfortunately still large and non-transactional as a lot of changes must be done in once to make code compilable.