Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor basic crypto to not use raw pointers. #2303

Merged
merged 10 commits into from
Jan 5, 2025

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Dec 23, 2024

This PR continues work, done in PR #2292 . Unfortunately still large and non-transactional as a lot of changes must be done in once to make code compilable.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 95.80052% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (cd9ca84) to head (16137d3).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/crypto/rsa_ossl.cpp 75.00% 7 Missing ⚠️
src/lib/key_material.cpp 87.23% 6 Missing ⚠️
src/librepgp/stream-parse.cpp 92.85% 2 Missing ⚠️
src/lib/crypto/ecdh_ossl.cpp 98.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2303      +/-   ##
==========================================
+ Coverage   84.88%   84.90%   +0.02%     
==========================================
  Files         114      114              
  Lines       22784    22789       +5     
==========================================
+ Hits        19340    19350      +10     
+ Misses       3444     3439       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-further-refactor-basics branch from c901c3f to 16137d3 Compare December 23, 2024 17:14
@ni4 ni4 requested review from desvxx, ronaldtse and maxirmx December 23, 2024 18:35
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxirmx
Copy link
Member

maxirmx commented Jan 5, 2025

Megimg with 2 approvals

@maxirmx maxirmx merged commit 7e67d35 into main Jan 5, 2025
123 checks passed
@maxirmx maxirmx deleted the ni4-further-refactor-basics branch January 5, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants