Fixed conversion between utf-8 and utf-16 for Windows build #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2301 +/- ##
==========================================
- Coverage 84.88% 84.88% -0.01%
==========================================
Files 114 114
Lines 22785 22783 -2
==========================================
- Hits 19341 19339 -2
Misses 3444 3444 ☔ View full report in Codecov by Sentry. |
|
This PR is needed for integrating librnp into our project (retroshare), otherwise it won't compile on windows. |
|
...related issue: #2302 |
|
Merging with two approvals. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to use std::codecvt_utf8_utf16<wchar_t> instead of std::codecvt_utf8<wchar_t> for the conversion between utf-8 and utf-16 for Windows build.
Is there a flag or switch I need to set to make it work without this change?
I am using MinGW 8.1
gcc (x86_64-posix-seh-rev0, created by the MinGW-W64 project) 8.1.0