Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove path prefix in RNP_LOG #2297

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

desvxx
Copy link
Contributor

@desvxx desvxx commented Dec 5, 2024

fixes #2146

@desvxx desvxx force-pushed the desvxx-2146-remove-prefix-in-rnp_log branch from 8e1ea80 to eef0043 Compare December 5, 2024 21:00
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (ec78117) to head (aa23507).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2297   +/-   ##
=======================================
  Coverage   84.88%   84.88%           
=======================================
  Files         114      114           
  Lines       22783    22783           
=======================================
  Hits        19339    19339           
  Misses       3444     3444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on the assumption that compiler sets FILE to the file name from the command line.

I am not sure if it works for MSVC

@desvxx
Copy link
Contributor Author

desvxx commented Dec 11, 2024

This is based on the assumption that compiler sets FILE to the file name from the command line.

I am not sure if it works for MSVC

https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170

Indeed, looks like we need /FC option for msvc.

@maxirmx
Copy link
Member

maxirmx commented Dec 11, 2024

https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170

Indeed, looks like we need /FC option for msvc.

I think it is safe to add /FC option

Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some line to cli_tests.py, which makes sure that prefix is not included. This would work for any output made with RNP_LOG, like self.assertRegex(err, r'(?s)^.*Warning: missing or malformed CRC line.*').
Also please rebase so all tests are run (macOS runner was renewed).

@desvxx desvxx force-pushed the desvxx-2146-remove-prefix-in-rnp_log branch from eef0043 to d63a0e7 Compare January 5, 2025 15:23
@desvxx desvxx force-pushed the desvxx-2146-remove-prefix-in-rnp_log branch from 176dace to aa23507 Compare January 5, 2025 18:39
@desvxx desvxx requested a review from ni4 January 5, 2025 21:01
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ni4 ni4 merged commit 884b52b into main Jan 6, 2025
123 checks passed
@ni4 ni4 deleted the desvxx-2146-remove-prefix-in-rnp_log branch January 6, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not print a full source path in RNP_LOG.
3 participants