Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default s2k tuning test ratio to 4. #2290

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Nov 11, 2024

Fixes #2289

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (0fc76d5) to head (de62cf2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2290   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         116      116           
  Lines       23292    23292           
=======================================
  Hits        19755    19755           
  Misses       3537     3537           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 requested review from ronaldtse, maxirmx and desvxx November 11, 2024 16:02
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni4
Copy link
Contributor Author

ni4 commented Nov 12, 2024

Let's merge this with a single approval as a CI-only.

@ni4 ni4 merged commit 3bd1b71 into main Nov 12, 2024
124 checks passed
@ni4 ni4 deleted the ni4-2289-reduce-s2k-tuning-time branch November 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s2k_iteration_tuning test failure in 0.17.1
2 participants