Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to cover bz.avail_out == 0 #2277

Conversation

desvxx
Copy link
Contributor

@desvxx desvxx commented Sep 28, 2024

fixes #2229

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (7724682) to head (e3e9e81).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
+ Coverage   84.02%   84.06%   +0.04%     
==========================================
  Files         114      114              
  Lines       23062    23062              
==========================================
+ Hits        19377    19388      +11     
+ Misses       3685     3674      -11     
Flag Coverage Δ
84.06% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desvxx desvxx force-pushed the desvxx-2229-add-testcases-to-cover-compression-corner-cases branch from d475776 to e3e9e81 Compare September 28, 2024 21:42
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni4
Copy link
Contributor

ni4 commented Oct 4, 2024

Thanks, merging with two approvals!

@ni4 ni4 merged commit 9329129 into rnpgp:main Oct 4, 2024
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test case which covers bz->avail_out overflow.
3 participants