Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on a bunch of rnp_op_verify_t calls. #2258

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Aug 2, 2024

Fixes #2257

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (e3662a7) to head (ae2c368).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2258      +/-   ##
==========================================
- Coverage   83.58%   83.56%   -0.02%     
==========================================
  Files         107      107              
  Lines       23163    23163              
==========================================
- Hits        19360    19356       -4     
- Misses       3803     3807       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-update-verify-signature-doc branch from 5bd72bd to ae2c368 Compare August 22, 2024 15:34
@ni4 ni4 marked this pull request as ready for review August 22, 2024 18:34
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ni4
Copy link
Contributor Author

ni4 commented Aug 24, 2024

Merging with single approval as documentation-only.

@ni4 ni4 merged commit 45e3392 into main Aug 24, 2024
122 of 123 checks passed
@ni4 ni4 deleted the ni4-update-verify-signature-doc branch August 24, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing destructor for rnp_op_verify_signature_t ?
2 participants