Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EOLed centos 7 from the CI. #2251

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Remove EOLed centos 7 from the CI. #2251

merged 1 commit into from
Jul 23, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Jul 22, 2024

Fixes #2201

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (6224061) to head (bb41d2c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2251      +/-   ##
==========================================
- Coverage   83.58%   83.58%   -0.01%     
==========================================
  Files         107      107              
  Lines       23161    23161              
==========================================
- Hits        19359    19358       -1     
- Misses       3802     3803       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 marked this pull request as ready for review July 22, 2024 17:22
@ni4 ni4 requested review from ronaldtse, maxirmx and desvxx July 22, 2024 17:23
maxirmx
maxirmx approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will make CI much easier :)

@ni4
Copy link
Contributor Author

ni4 commented Jul 23, 2024

Thanks, @maxirmx ! Merging with one approval as CI-only.

@ni4 ni4 merged commit 7daffcf into main Jul 23, 2024
109 checks passed
@ni4 ni4 deleted the ni4-2201-ci-remove-centos-7 branch July 23, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxirmx maxirmx maxirmx approved these changes

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

@desvxx desvxx Awaiting requested review from desvxx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Remove CentOS 7 runners when it EOLs at June, 2024.
2 participants
@ni4 @maxirmx