Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rnp_signature_get_features #2188

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

kaie
Copy link
Contributor

@kaie kaie commented Feb 6, 2024

No description provided.

@ni4
Copy link
Contributor

ni4 commented Feb 6, 2024

@kaie Thanks for the submission! Could you please add the following test calls (as I cannot push to your fork) to make codecov happier:

assert_rnp_failure(rnp_signature_get_features(NULL, &features));
assert_rnp_failure(rnp_signature_get_features(sig, NULL));

@kaie
Copy link
Contributor Author

kaie commented Feb 6, 2024

@kaie Thanks for the submission! Could you please add the following test calls (as I cannot push to your fork) to make codecov happier:

assert_rnp_failure(rnp_signature_get_features(NULL, &features));
assert_rnp_failure(rnp_signature_get_features(sig, NULL));

good suggestion, done

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3d1a3d5) 77.24% compared to head (2ce007a) 77.24%.

Files Patch % Lines
src/lib/rnp.cpp 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2188   +/-   ##
=======================================
  Coverage   77.24%   77.24%           
=======================================
  Files         194      194           
  Lines       37731    37742   +11     
=======================================
+ Hits        29145    29154    +9     
- Misses       8586     8588    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ni4
Copy link
Contributor

ni4 commented Feb 8, 2024

Thank you guys!
Two approvals == merge.

@ni4 ni4 merged commit 9e5e13a into rnpgp:main Feb 8, 2024
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants