Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update FreeBSD image version for Cirrus runner. #2172

Merged
merged 7 commits into from
Jan 19, 2024
Merged

CI: Update FreeBSD image version for Cirrus runner. #2172

merged 7 commits into from
Jan 19, 2024

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Jan 5, 2024

Fixes #2170

@ni4 ni4 force-pushed the ni4-2170-bump-freebsd-runner-version branch from f6101a9 to ebcdb96 Compare January 5, 2024 16:49
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2cf8fd2) 77.07% compared to head (a4c52eb) 77.07%.

Files Patch % Lines
src/tests/ffi-enc.cpp 0.00% 4 Missing ⚠️
src/lib/crypto/backend_version.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2172   +/-   ##
=======================================
  Coverage   77.07%   77.07%           
=======================================
  Files         194      194           
  Lines       37257    37258    +1     
=======================================
+ Hits        28715    28717    +2     
+ Misses       8542     8541    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-2170-bump-freebsd-runner-version branch 9 times, most recently from 1b16c11 to 085ad8a Compare January 11, 2024 14:18
@ni4 ni4 mentioned this pull request Jan 12, 2024
Closed
@ni4 ni4 force-pushed the ni4-2170-bump-freebsd-runner-version branch from 085ad8a to c71080d Compare January 16, 2024 12:06
@ni4 ni4 mentioned this pull request Jan 16, 2024
Closed
@ni4 ni4 force-pushed the ni4-2170-bump-freebsd-runner-version branch from b56606e to a4c52eb Compare January 16, 2024 15:53
@ni4 ni4 requested review from ronaldtse and maxirmx January 16, 2024 17:53
@ni4
Copy link
Contributor Author

ni4 commented Jan 16, 2024

Let's ignore codecov-patch failure for now. Please don't merge before @cedral reply in #2171

maxirmx
maxirmx approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ronaldtse
ronaldtse approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ni4 !

@ni4
Copy link
Contributor Author

ni4 commented Jan 19, 2024

Let's merge it to have other PRs running, hope @cedral do not mind.

@ni4 ni4 merged commit 86ef400 into main Jan 19, 2024
116 of 117 checks passed
@ni4 ni4 deleted the ni4-2170-bump-freebsd-runner-version branch January 19, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxirmx maxirmx maxirmx approved these changes

@ronaldtse ronaldtse ronaldtse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CI as FreeBSD 12 EOLed
4 participants
@ni4 @ronaldtse @maxirmx @cedral