Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalized CI refactoring #2137

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Finalized CI refactoring #2137

merged 1 commit into from
Oct 29, 2023

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Oct 26, 2023

The goal set in #1968 "to get rid of the ci/ folder" is now achieved
ci/ folder now conatains tests scripts for shUnit2 tests and configuration files for botan

All shell build scripts have been moved to ci-legacy folder to be sure that they are not used in CI.
We can either delete them or keep as needed.

@maxirmx maxirmx linked an issue Oct 26, 2023 that may be closed by this pull request
5 tasks
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65356e1) 76.88% compared to head (0e5c77b) 76.88%.

❗ Current head 0e5c77b differs from pull request most recent head 9f2d6e9. Consider uploading reports for the commit 9f2d6e9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2137      +/-   ##
==========================================
- Coverage   76.88%   76.88%   -0.01%     
==========================================
  Files         193      193              
  Lines       36982    36982              
==========================================
- Hits        28433    28432       -1     
- Misses       8549     8550       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxirmx maxirmx force-pushed the maxirmx-finalize-ci-refactoring branch from 42fe8e8 to 86e440f Compare October 27, 2023 14:25
@maxirmx maxirmx changed the title Finalizing CI refactoring Finalized CI refactoring Oct 27, 2023
@maxirmx maxirmx force-pushed the maxirmx-finalize-ci-refactoring branch 3 times, most recently from b0a758d to 9f2d6e9 Compare October 28, 2023 18:22
@maxirmx maxirmx marked this pull request as ready for review October 28, 2023 20:58
@maxirmx maxirmx requested review from ni4 and ronaldtse October 28, 2023 21:08
@ronaldtse ronaldtse merged commit 05f59e9 into main Oct 29, 2023
213 checks passed
@ronaldtse
Copy link
Contributor

Thank you @maxirmx !

@ronaldtse ronaldtse deleted the maxirmx-finalize-ci-refactoring branch October 29, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CI workflows to use GitHub Actions capabilities
2 participants