-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native barcode scanning on iOS #119
Use native barcode scanning on iOS #119
Conversation
@DwayneCoussement bar codes seem broken |
# Conflicts: # example/ios/Podfile.lock # example/ios/Runner.xcodeproj/project.pbxproj
My apologies for that; I do think we need to parameterize that part as well though. |
@rmtmckenzie Could you please take a look at this? |
@rmtmckenzie Is this going to be merged? This package is very useful but the Pull-Requests are lagging behind and the issues are not being updated. Could be worthwhile to hand it over to someone who got the time to maintain it. |
Hi @SiavoshZarrasvand. I've been way too busy the last while, but this was also not the direction I wanted to go with the plugin - I've released a new version using FirebaseMobileVision. It took a while especially because I wanted to make sure my app with it integrated would actually be accepted by apple, which is has now. If you're wanting to use the native barcode scanning I fully encourage you to keep a fork and publish it independently on pub.dev. I do have a long-term plan to support different backends, but I also can't commit to any timeline to getting it done. See #121 though and if you think you'd like to use that give it a +1. If I start seeing a significant amount of support for it that will definitely encourage me to actually spend the time on it. |
Done. Where is the new release, is that in the master branch? |
It's on the master branch as well as on pub.dev |
Hey, I don’t think that having different implementations brings a lot of value at the current moment; unless you’d exclude your dependencies at build time. I went native because adding firebase for “just” scanning QR-codes in my case was a huge overhead on app size and couldn’t guarantee the user’s privacy as I’d want it to. If you’d have multiple implementations and libs in your podspec you’d not solve this problem; as libraries have access the moment they are included. However I wanted to ask following questions here:
|
@DwayneCoussement My idea was to split the dependencies into separate plugins, so in your app you'd include for example I also investigated simply using the |
For Huawei phones and the china region, I'm not 100% sure what the upgrade to firebase means - but the current (released) implementation uses Google Mobile Vision and is heavily reliant on google play services, so the behaviour hasn't changed. Oh but I've also just found this: https://firebase.google.cn/ - I think the firebase team has made firebase available for users in China through that endpoint. I have no idea how one would go about hooking that up in the app though - maybe by releasing a separate version of the app with an alternate firebase configuration, just for the chinese market? |
This Pull Request brings native iOS barcode scanning. This should fix the UIWebView references which could cause rejection by Apple's App Store.
Motivation: in April 2020 Apple won't accept any new apps with UIWebView in them anymore. In December 2020, existing apps have the same destiny. GoogleMobileVision still has this and has been moved to Firebase. So either going full native or adding the Firebase variant was a solution.
As of the current moment; native seemed the better solution (build times are lower if you don't have any other Firebase usage in your Flutter app, no need to have apikeys etc etc).
See also: https://developer.apple.com/news/?id=12232019b