Skip to content

Commit

Permalink
Merge pull request #19 from rmrs/bugfix-android-compile-warning-glide…
Browse files Browse the repository at this point in the history
…-4-9-0

Fix Android "Configuration 'compile' is obsolete" warning
  • Loading branch information
erezrokah authored Mar 18, 2019
2 parents a598939 + 57cf3f7 commit 49eaae6
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 12 deletions.
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"javascript.preferences.quoteStyle": "single",
"editor.formatOnSave": false
"editor.formatOnSave": false,
"java.configuration.updateBuildConfiguration": "disabled"
}
23 changes: 13 additions & 10 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

buildscript {
repositories {
Expand All @@ -12,12 +15,12 @@ buildscript {
apply plugin: 'com.android.library'

android {
compileSdkVersion 26
buildToolsVersion "25.0.3"
compileSdkVersion safeExtGet('compileSdkVersion', 26)
buildToolsVersion safeExtGet('buildToolsVersion', "25.0.3")

defaultConfig {
minSdkVersion 16
targetSdkVersion 26
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 26)
versionCode 1
versionName "1.0"
}
Expand All @@ -34,18 +37,18 @@ repositories {
}

dependencies {
compile 'com.facebook.react:react-native:+'
implementation 'com.facebook.react:react-native:+'

// glide dependencies
compile 'com.github.bumptech.glide:glide:4.2.0'
annotationProcessor 'com.github.bumptech.glide:compiler:4.2.0'
implementation 'com.github.bumptech.glide:glide:4.9.0'
annotationProcessor 'com.github.bumptech.glide:compiler:4.9.0'

// FirebaseUI Storage only
compile 'com.firebaseui:firebase-ui-storage:3.0.0'
implementation 'com.firebaseui:firebase-ui-storage:3.0.0'

// PhotoView
compile 'com.github.chrisbanes:PhotoView:2.1.3'
implementation 'com.github.chrisbanes:PhotoView:2.1.3'

// glide-transformations
compile 'jp.wasabeef:glide-transformations:3.0.1'
implementation 'jp.wasabeef:glide-transformations:3.0.1'
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-firebaseui",
"version": "v0.1.1",
"version": "v0.1.2",
"description": "React Native Firebase Bindings Based on FirebaseUI SDK",
"main": "index.js",
"repository": {
Expand Down

0 comments on commit 49eaae6

Please sign in to comment.