Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a -q/--quiet flag #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a -q/--quiet flag #97

wants to merge 1 commit into from

Conversation

eklitzke
Copy link
Contributor

@eklitzke eklitzke commented Mar 3, 2018

I find the default warning message about empty reports to be annoying. This adds a -q/--quiet flag that will suppress the warning log level.

I'm not 100% this is correct because with this change wrapper_environment() still creates ENVIRONMENT_KEY with a "verbose" key that does not consider the value of args.quiet. I'm open to handling this another way too, the way the argument handling and log setting works seemed kind of weird to me.

@rizsotto
Copy link
Owner

rizsotto commented Mar 4, 2018

Thanks to look into it. Will think how would it be more silent. Currently this mimics the Clang scan-build command about the output directory handling and reporting. Also a few tests relies on the current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants