Support custom rz-pm-db URL #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ret2libc
reviewed
Mar 22, 2024
XVilka
requested changes
Mar 24, 2024
|
All changes addressed. Thanks, guys ❤️ |
XVilka
requested changes
Mar 25, 2024
XVilka
requested changes
Mar 25, 2024
ret2libc
approved these changes
Mar 26, 2024
XVilka
approved these changes
Mar 26, 2024
pkg/database.go
Outdated
| @@ -24,12 +24,14 @@ var ErrRizinPackageWrongHash = errors.New("wrong hash") | |||
|
|
|||
| const dbPath string = "db" | |||
|
|
|||
| func InitDatabase(path string, rizinVersion string) (Database, error) { | |||
| func InitDatabase(path string, rizinVersion string, shouldUpdateDB bool) (Database, error) { | |||
There was a problem hiding this comment.
Damn. I thought I got them all. Fixed!
And add a log line when downloading a package which is very useful to tell the user the project didn't hang: it's just downloading slowly.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys. This PR adds an environment variable to support a custom rz-pm-db.
It also adds a new flag to disable DB updatesa
Finally, I also added a log line to tell the user the package is downloading. This is purely for sanity purposes since I thought multiple times the binary hanged when it was just downloading a large repo.
I've added an explanation for this in the README