Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52 refactor tasks #63

Merged
merged 11 commits into from
Apr 26, 2022
Merged

#52 refactor tasks #63

merged 11 commits into from
Apr 26, 2022

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Apr 24, 2022

This PR ticks most boxes in #52.

Namely:

  • Fix grammar/spelling issues (handwritten -> hand-written)

  • Move the foloowing pattern in its own function

    with open("handwritten/hexagon_il_h/include.h") as include:
      set_pos_after_license(include)
      code += "".join(include.readlines())
  • Move the following pattern in its own function:

    if compare_src_to_old_src(code, path):
       self.unchanged_files.append(path)
       return
    with open(path, "w+") as dest:
       dest.writelines(code)
       log("analysis_hexagon.c written to {}".format(path), LogLevel.INFO)
  • Replaced "..".format() patterns with f"..." formatting in Generate instruction templates as C structs #60

  • Refactor parse_instruction()
    The method for parsing a Duplex or normal instruction are almost the same.
    The method should be in InstructionTemplate from which DuplexInstruction and Instruction inherit.

    Methods in question:

    def parse_instruction(self) -> None:

    def parse_instruction(self) -> None:

  • Update license date

  • Remove or include out-commented code (mostly logs)

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Member

@thestr4ng3r thestr4ng3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rot127 Rot127 requested a review from thestr4ng3r April 25, 2022 11:14
@Rot127 Rot127 merged commit 2be75aa into rizinorg:master Apr 26, 2022
@Rot127 Rot127 deleted the Refactor branch June 3, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants