-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#52 refactor tasks #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XVilka
approved these changes
Apr 24, 2022
thestr4ng3r
requested changes
Apr 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"handwritten" is the correct form: https://dictionary.cambridge.org/de/worterbuch/englisch/handwritten
thestr4ng3r
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ticks most boxes in #52.
Namely:
Fix grammar/spelling issues (handwritten
->hand-written
)Move the foloowing pattern in its own function
Move the following pattern in its own function:
Replaced
"..".format()
patterns withf"..."
formatting in Generate instruction templates as C structs #60Refactor
parse_instruction()
The method for parsing a Duplex or normal instruction are almost the same.
The method should be in
InstructionTemplate
from whichDuplexInstruction
andInstruction
inherit.Methods in question:
rz-hexagon/DuplexInstruction.py
Line 99 in 7df09f5
rz-hexagon/Instruction.py
Line 106 in 7df09f5
Update license date
Remove or include out-commented code (mostly logs)