Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rizin book to rizin 0.7.3 usage #130

Merged
merged 11 commits into from
Dec 4, 2024

Conversation

winterheart
Copy link
Contributor

Update most of rizin invocations, remove deprecated and removed stuff.
Add simple C99-compliant program "hello_world" which will be used in examples.
Fix internal links and improve spelling.

@winterheart winterheart force-pushed the update-to-rizin-0.7.3 branch from 1a5e893 to b12e56d Compare November 18, 2024 09:04
@winterheart
Copy link
Contributor Author

@wargio "Analysis" chapter was updated based on your review.

src/analysis/graphs.md Outdated Show resolved Hide resolved
src/analysis/graphs.md Outdated Show resolved Hide resolved
src/analysis/signatures.md Outdated Show resolved Hide resolved
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not split the lines in the markdown, the tool we use will do it properly for each output.

@wargio
Copy link
Member

wargio commented Nov 18, 2024

I have not finished reviewing this since there are a lot of changes. i will try my best to finish this asap.

@wargio wargio requested a review from XVilka November 18, 2024 12:21
@winterheart winterheart force-pushed the update-to-rizin-0.7.3 branch from b12e56d to 6aea95c Compare November 23, 2024 12:30
@winterheart
Copy link
Contributor Author

@wargio fixed based on review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced image files with actual text output, so files now redundant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this has been removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unused in book, and it's duplicate entries from "analysis/types.md".

@winterheart winterheart force-pushed the update-to-rizin-0.7.3 branch 3 times, most recently from 89170ed to b092253 Compare November 26, 2024 22:19
src/analysis/graphs.md Outdated Show resolved Hide resolved
src/analysis/variables.md Outdated Show resolved Hide resolved
src/analysis/variables.md Outdated Show resolved Hide resolved
@winterheart winterheart force-pushed the update-to-rizin-0.7.3 branch from b092253 to 2c328b3 Compare November 27, 2024 12:02
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes overall, but in many places grammar is off. Please check on that.

src/analysis/code_analysis.md Outdated Show resolved Hide resolved
src/analysis/code_analysis.md Outdated Show resolved Hide resolved
src/analysis/code_analysis.md Outdated Show resolved Hide resolved
src/analysis/code_analysis.md Outdated Show resolved Hide resolved

For partial emulation (or imprecise full emulation) rizin uses its own
For partial emulation (or imprecise full emulation) Rizin uses its own
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Rizin supports RzIL for many architectures already, it probably makes sense to expand this chapter with RzIL as well. cc @Rot127
It also worth to mention that ESIL in the future will be deprecated in favor of RzIL once the conversion is completed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't have enough experience using this feature. I changed the text as best I could, but this section requires edits from a more experienced editor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it is ok to add it later.

src/basic_commands/mapping_files.md Show resolved Hide resolved
src/debugger/revdebug.md Outdated Show resolved Hide resolved
src/disassembling/adding_metadata.md Outdated Show resolved Hide resolved
src/disassembling/intro.md Outdated Show resolved Hide resolved
src/scripting/macros.md Show resolved Hide resolved
Update most of rizin invocations, remove deprecated and removed stuff.
Replace images of print modes with code listings.
Add simple C99-compliant program "hello_world" which will be used in examples.
Remove unreferenced "Working with data types" section as it not linked to chapter and duplicated by "Working with data types" from "Analysis" chapter.

For all changed command invocation was used rizin @ dev (d2bd9406a).
Update most of rizin invocations, remove deprecated and removed stuff.
Fix internal links and improve spelling.
Use "hello_world" as example.

For all changed command invocation was used rizin 0.7.3.
Improve spelling.
Update most of rizin invocations, remove deprecated and removed stuff.

For all changed command invocation was used rizin 0.7.3.
Improve spelling.
Update most of rizin invocations, remove deprecated and removed stuff.

For all changed command invocation was used rizin 0.7.3.
Improve spelling, use common Markdown syntax.
Improve spelling, use common Markdown syntax.
Update most of rizin invocations, remove deprecated and removed stuff.

For all changed command invocation was used rizin 0.7.3.
Improve spelling.
Update most of rizin invocations.

For all changed command invocation was used rizin 0.7.3.
Improve spelling.
Update most of rizin invocations.

For all changed command invocation was used rizin 0.7.3.
Improve spelling, use common Markdown syntax.
Improve spelling, use common Markdown syntax.
Update most of rizin invocations.

For all changed command invocation was used rizin 0.7.3.
@winterheart winterheart force-pushed the update-to-rizin-0.7.3 branch from 2c328b3 to 8286b52 Compare November 28, 2024 22:16
@wargio wargio merged commit 7de5cd7 into rizinorg:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants