-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rizin book to rizin 0.7.3 usage #130
Conversation
1a5e893
to
b12e56d
Compare
@wargio "Analysis" chapter was updated based on your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not split the lines in the markdown, the tool we use will do it properly for each output.
I have not finished reviewing this since there are a lot of changes. i will try my best to finish this asap. |
b12e56d
to
6aea95c
Compare
@wargio fixed based on review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are not used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replaced image files with actual text output, so files now redundant.
src/basic_commands/types.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this has been removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unused in book, and it's duplicate entries from "analysis/types.md".
89170ed
to
b092253
Compare
b092253
to
2c328b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes overall, but in many places grammar is off. Please check on that.
src/analysis/emulation.md
Outdated
|
||
For partial emulation (or imprecise full emulation) rizin uses its own | ||
For partial emulation (or imprecise full emulation) Rizin uses its own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Rizin supports RzIL for many architectures already, it probably makes sense to expand this chapter with RzIL as well. cc @Rot127
It also worth to mention that ESIL in the future will be deprecated in favor of RzIL once the conversion is completed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't have enough experience using this feature. I changed the text as best I could, but this section requires edits from a more experienced editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it is ok to add it later.
Update most of rizin invocations, remove deprecated and removed stuff. Replace images of print modes with code listings. Add simple C99-compliant program "hello_world" which will be used in examples. Remove unreferenced "Working with data types" section as it not linked to chapter and duplicated by "Working with data types" from "Analysis" chapter. For all changed command invocation was used rizin @ dev (d2bd9406a).
Update most of rizin invocations, remove deprecated and removed stuff. Fix internal links and improve spelling. Use "hello_world" as example. For all changed command invocation was used rizin 0.7.3.
Improve spelling.
Improve spelling. Update most of rizin invocations, remove deprecated and removed stuff. For all changed command invocation was used rizin 0.7.3.
Improve spelling. Update most of rizin invocations, remove deprecated and removed stuff. For all changed command invocation was used rizin 0.7.3.
Improve spelling, use common Markdown syntax.
Improve spelling, use common Markdown syntax. Update most of rizin invocations, remove deprecated and removed stuff. For all changed command invocation was used rizin 0.7.3.
Improve spelling. Update most of rizin invocations. For all changed command invocation was used rizin 0.7.3.
Improve spelling. Update most of rizin invocations. For all changed command invocation was used rizin 0.7.3.
Improve spelling, use common Markdown syntax.
Improve spelling, use common Markdown syntax. Update most of rizin invocations. For all changed command invocation was used rizin 0.7.3.
2c328b3
to
8286b52
Compare
Update most of rizin invocations, remove deprecated and removed stuff.
Add simple C99-compliant program "hello_world" which will be used in examples.
Fix internal links and improve spelling.