Fix invalid go generation #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoNekoD
commented
Apr 21, 2024
| @@ -57,7 +57,7 @@ private function convertEnumToGoEnumProperties(array $properties, string $enum): | |||
| } | |||
| $this->usedConstantsStore[] = $const; | |||
|
|
|||
| $spaces = str_repeat(' ', $maxEnumPropNameLength - strlen($prop->getName()) + 1); | |||
KoNekoD
commented
Apr 21, 2024
| $type->equalsTo(PhpBaseType::array()), | ||
| $type->equalsTo(PhpBaseType::iterable()) => '[]interface{}', |
KoNekoD
commented
Apr 21, 2024
| // THE FILE WAS AUTOGENERATED USING PHP-CONVERTER. PLEASE DO NOT EDIT IT! | ||
| // Code generated by php-converter. DO NOT EDIT. | ||
| // Code generated by php-converter. DO NOT EDIT. | ||
| // Code generated by php-converter. DO NOT EDIT. |
KoNekoD
commented
Apr 21, 2024
| @@ -9,6 +9,8 @@ final class PermissionsEnum extends Enum | |||
| private const VIEW = 'view'; | |||
|
|
|||
| private const EDIT = 'edit'; | |||
|
|
|||
| private const CREATE_EXTRA_SUPER_FILE = 'create-extra-super-file'; | |||
There was a problem hiding this comment.
created to detect err 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Enum types do not indent correctly
2 []interface{} is a logical error of mine, it should be just interface{}
3 I wrote the comment that the file is generated by convention, it does not appear in the ide that it is a generated file.