Use new windows-bindgen #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
commented
Dec 3, 2024
src/bindings.rs
Outdated
| iid == &<IState as windows_core::Interface>::IID | ||
| } | ||
| } | ||
| pub mod Windows { |
There was a problem hiding this comment.
This is the problem. The bool type got regenerated.
youyuanwu
commented
Dec 3, 2024
| @@ -1,6 +1,20 @@ | |||
| import "objidl.idl"; | |||
| import "oaidl.idl"; | |||
| import "propidl.idl"; | |||
| // import "wtypes.idl"; | |||
|
|
|||
| typedef struct StateData | |||
There was a problem hiding this comment.
If this struct is removed, and getbool() returns BOOLEAN, bindgen can correctly reference windows crate BOOLEAN type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
Using the PR: microsoft/windows-rs#3359
There are issues with the new bindgen that this PR will keep uncoverring with small repro code gen scenarios.